Switch isDevToolsServerAvailable to not depend on the SSE connection #9024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
My recent change to disable the SSE connection when running embedded had an unintended side-effect. There's a number of places that check `isDevToolsServerAvailable` to see if they can call the HTTP API (and to set up server-side storage), however this was checking whether the SSE connection was made, not only that the server was available. This change moves the server API check out of `DevToolsServerConnection` (which is basically the SSE API) and sets the storage (and therefore `isDevToolsServerAvailable`) based on just the HTTP API regardless of SSE, and then only attempts to connect SSE after. Fixes flutter#9023
DanTup
commented
Mar 12, 2025
Comment on lines
38
to
+42
| /// Since the DevTools server is a web server, it is only available for the | ||
| /// web platform. | ||
| /// | ||
| /// TODO(dantup): Since this relates only to non-SSE API, it could be available | ||
| /// for non-web? |
Contributor
Author
There was a problem hiding this comment.
I'm not sure of the logic behind this comment, but wonder if maybe it was because of SSE (and maybe package:sse only worked for web?). I feel like we should (in theory) be able to run the server and connect a desktop version of DevTools to it, which makes this comment incorrect?
kenzieschmoll
approved these changes
Mar 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My recent change to disable the SSE connection when running embedded had an unintended side-effect. There's a number of places that check
isDevToolsServerAvailableto see if they can call the HTTP API (and to set up server-side storage), however this was checking whether the SSE connection was made, not only that the server was available.This change moves the server API check out of
DevToolsServerConnection(which is basically the SSE API) and sets the storage (and thereforeisDevToolsServerAvailable) based on just the HTTP API regardless of SSE, and then only attempts to connect SSE after.Fixes #9023