Skip to content

Update to latest Flutter candidate version and resolve failing benchmark tests #9466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
elliette merged 3 commits into from
Oct 15, 2025
Merged

Update to latest Flutter candidate version and resolve failing benchmark tests #9466

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ecb3cb2
Update to latest Flutter candidate version
elliette Oct 14, 2025
56dc6d7
Hardcode value and update comment
elliette Oct 15, 2025
940c6b6
Format
elliette Oct 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion flutter-candidate.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
86327198ff0678f46cbdfb3e12f1759d03aa768d
c63c6b08a7114517575bcf3e45275ec7a9f4e87f
7 changes: 6 additions & 1 deletion packages/devtools_app/benchmark/devtools_benchmarks_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,12 @@ Future<void> _runBenchmarks({bool useWasm = false}) async {

for (final devToolsBenchmark in DevToolsBenchmark.values) {
final benchmarkName = devToolsBenchmark.id;
final expectedMetrics = expectedBenchmarkMetrics(useWasm: useWasm);
// Note: Due to https://github.com/flutter/flutter/pull/175392 there is no
// longer any difference in benchmark events for skwasm vs. canvaskit.
//
// TODO(https://github.com/flutter/flutter/issues/177057): Remove hardcoded
// useWasm: false param when package:web_benchmarks is updated.
final expectedMetrics = expectedBenchmarkMetrics(useWasm: false);
const expectedComputations = BenchmarkMetricComputation.values;
final scores = taskResult.scores[benchmarkName] ?? [];
expect(
Expand Down
Loading