Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Fix empty composing range on iOS #10381

Merged
goderbauer merged 2 commits into from
Aug 7, 2019
Merged

Fix empty composing range on iOS #10381

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
44f75e7
Fix empty composing range on iOS
goderbauer Aug 1, 2019
31b8d03
review feedback
goderbauer Aug 5, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions shell/platform/darwin/ios/framework/Source/FlutterTextInputPlugin.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -591,8 +591,9 @@ - (void)updateEditingState {
NSUInteger selectionBase = ((FlutterTextPosition*)_selectedTextRange.start).index;
NSUInteger selectionExtent = ((FlutterTextPosition*)_selectedTextRange.end).index;

NSUInteger composingBase = 0;
NSUInteger composingExtent = 0;
// Empty compositing range is represented by the framework's TextRange.empty.
NSInteger composingBase = -1;
NSInteger composingExtent = -1;
if (self.markedTextRange != nil) {
composingBase = ((FlutterTextPosition*)self.markedTextRange.start).index;
composingExtent = ((FlutterTextPosition*)self.markedTextRange.end).index;
Expand Down