Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@chinmaygarde
Copy link
Contributor

No description provided.

@chinmaygarde
Copy link
Contributor Author

This is related to the comment @stuartmorgan made on another commit about shadowing in lambda captures. I incorrectly stated that this would have been caught with the default shadowing warning flags. This is not true apparently and all shadowing flags are only enabled via the -Wshadow-all flag. We cannot yet enable the same because Skia headers don't fully compile with the stricter warnings. But I will patch them one by one and enable the strictest set of flags. We can also use the current spot to enable Flutter specific warnings in the engine.

@chinmaygarde
Copy link
Contributor Author

Ah, I guess I can also use --system-header-prefix. I don't think it is reasonable for stuff in third_party/ to have to adhere to our warning flags.

@chinmaygarde
Copy link
Contributor Author

Fails on Fuchsia headers. Will retry again later.

@chinmaygarde chinmaygarde deleted the shadow branch August 9, 2019 03:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants