This repository was archived by the owner on Feb 25, 2025. It is now read-only.
buildfix: support build windows release/profile mode(#32746) #11475
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuartmorgan-g
suggested changes
Aug 27, 2019
Contributor
|
Also, please add a link to the issue in the PR description. |
Contributor
Author
|
What about this PR? I think "Win release" should be added to googlebot's ci-task in the future. |
Contributor
stuartmorgan-g
left a comment
stuartmorgan-g
left a comment
There was a problem hiding this comment.
Sorry for the delay, I wasn't able to get to this yesterday.
WHAT:
buildbreak on Windows Release/Profile Mode.
WHY:
Windows platform does not link vm_snapshot_data.bin.o isolate_snapshot_instructions.bin.o vm_snapshot_instructions.bin.o vm_snapshot_data.bin.o generated by bin_to_coff.
HOW:
add deps to runtime build.gn
shoryukenn
force-pushed
the
bugfix_32746
branch
from
400de88 to
945503e
Compare
Contributor
Author
|
rebase upstream/master to fix checks failure on Linux task. |
|
I found it through a search and found that this PR can solve the problem. I'm already using it on my local code. Thanks a lot. |
chinmaygarde
approved these changes
Sep 3, 2019
Contributor
chinmaygarde
left a comment
chinmaygarde
left a comment
There was a problem hiding this comment.
Can we add a LUCI recipe for Windows profile/release please?
Contributor
Getting it building and uploading on LUCI is definitely on the roadmap for supporting profile and release builds in |
Contributor
Author
|
@stuartmorgan , Hi, may I ask about the review progress here? :) |
stuartmorgan-g
approved these changes
Sep 5, 2019
Contributor
stuartmorgan-g
left a comment
stuartmorgan-g
left a comment
There was a problem hiding this comment.
Chinmay is more familiar with this part of the engine, so marking my question as addressed.
Contributor
|
Sorry for the delay, I forgot my review was still showing as pending and had considered Chinmay's approval authoritative. I'll land this now. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 5, 2019
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Sep 5, 2019
git@github.com:flutter/engine.git/compare/cd920398e40e...edee1fe git log cd92039..edee1fe --no-merges --oneline 2019-09-05 egarciad@google.com Add @keep annotation (flutter/engine#11893) 2019-09-05 bkonyi@google.com Roll src/third_party/dart d0218d4771..be66176534 (11 commits) 2019-09-05 shihaohong@google.com Incorporate View.setSystemGestureExclusionRects code review feedback from #11441 (flutter/engine#11804) 2019-09-05 naifu.guan@gmail.com Support build windows release/profile embedding builds (flutter/engine#11475) 2019-09-05 skia-flutter-autoroll@skia.org Roll src/third_party/skia e784f75beb20..adecf4b6d5fe (6 commits) (flutter/engine#11900) 2019-09-05 xster@google.com remove extra redundant channels setup in iOS embedding engine (flutter/engine#11886) 2019-09-05 liyuqian@google.com Revert "Add a BroadcastStream to FrameTiming (#11041)" (flutter/engine#11841) 2019-09-05 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/linux-amd64 from OmqaW... to Z7PSg... (flutter/engine#11898) 2019-09-05 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from S-f_C... to -AQkJ... (flutter/engine#11897) 2019-09-05 skia-flutter-autoroll@skia.org Roll src/third_party/skia b0e2347fedfc..e784f75beb20 (1 commits) (flutter/engine#11896) 2019-09-05 bkonyi@google.com Roll src/third_party/dart 6eed35b60d..d0218d4771 (5 commits) 2019-09-05 skia-flutter-autoroll@skia.org Roll src/third_party/skia 97218352addb..b0e2347fedfc (4 commits) (flutter/engine#11894) 2019-09-05 bkonyi@google.com Roll src/third_party/dart 67bb2b7819..6eed35b60d (18 commits) 2019-09-05 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/linux-amd64 from LKWtB... to OmqaW... (flutter/engine#11891) 2019-09-05 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from m-hNV... to S-f_C... (flutter/engine#11889) 2019-09-05 skia-flutter-autoroll@skia.org Roll src/third_party/skia 166751ef578a..97218352addb (1 commits) (flutter/engine#11888) 2019-09-05 bkonyi@google.com Roll src/third_party/dart 08132661a6..67bb2b7819 (4 commits) 2019-09-04 franciscojma86@gmail.com Finish plumbing message responses on method channels (flutter/engine#11877) 2019-09-04 bkonyi@google.com Roll src/third_party/dart c3db2e3ee0..08132661a6 (2 commits) 2019-09-04 james@clarkezone.net [Windows] Address #36422 by adding a context for async resource uploading (flutter/engine#11828) 2019-09-04 skia-flutter-autoroll@skia.org Roll src/third_party/skia e7366841663b..166751ef578a (7 commits) (flutter/engine#11881) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC franciscojma@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.