Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Updated API usage in scenario app by deleting unnecessary method. #11844

Merged
matthew-carroll merged 3 commits into from
Sep 4, 2019
Merged

Updated API usage in scenario app by deleting unnecessary method. #11844

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
266e7d2
Updated API usage in scenario app by deleting unnecessary method.
matthew-carroll Sep 3, 2019
3638adf
PR Update.
matthew-carroll Sep 3, 2019
0fd2828
PR Updates
matthew-carroll Sep 4, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 1 addition & 8 deletions testing/scenario_app/android/app/src/main/java/dev/flutter/scenarios/MainActivity.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,11 +19,10 @@
import io.flutter.embedding.android.FlutterView;
import io.flutter.embedding.engine.FlutterEngine;
import io.flutter.embedding.engine.FlutterShellArgs;
import io.flutter.embedding.engine.renderer.OnFirstFrameRenderedListener;
import io.flutter.plugin.common.BasicMessageChannel;
import io.flutter.plugin.common.BinaryCodec;

public class MainActivity extends FlutterActivity implements OnFirstFrameRenderedListener {
public class MainActivity extends FlutterActivity {
final static String TAG = "Scenarios";

@Override
Expand All @@ -40,12 +39,6 @@ protected void onCreate(Bundle savedInstanceState) {
}
}

public void onFirstFrameRendered() {
Copy link
Contributor

@dnfield dnfield Sep 3, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You also want to get rid of the implements OnFirstFrameRenderedListener up there, as well as the import

Copy link
Contributor

@dnfield dnfield Sep 3, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(lines 22 and 26)

if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.KITKAT) {
reportFullyDrawn();
}
}

@Override
@NonNull
public FlutterShellArgs getFlutterShellArgs() {
Expand Down