Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[web_ui] add missing dispose handler for MethodCalls to flutter/platform_view #12226

Merged
harryterkelsen merged 2 commits into from
Sep 26, 2019
Merged

[web_ui] add missing dispose handler for MethodCalls to flutter/platform_view #12226

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
94fff25
added dispose handler for calls to flutter/platform_view
tauu Sep 11, 2019
07daca6
improved comment
tauu Sep 19, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions lib/web_ui/lib/src/engine/platform_views.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,9 @@ void handlePlatformViewCall(
case 'create':
_createPlatformView(decoded, callback);
return;
case 'dispose':
_disposePlatformView(decoded, callback);
return;
}
callback(null);
}
Expand All @@ -76,3 +79,15 @@ void _createPlatformView(
platformViewRegistry._createdViews[id] = element;
callback(codec.encodeSuccessEnvelope(null));
}

void _disposePlatformView(
MethodCall methodCall, ui.PlatformMessageResponseCallback callback) {
final int id = methodCall.arguments;
const MethodCodec codec = StandardMethodCodec();

// Remove the root element of the view from the DOM.
platformViewRegistry._createdViews[id]?.remove();
platformViewRegistry._createdViews.remove(id);

callback(codec.encodeSuccessEnvelope(null));
}