This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Reland "Smooth out iOS irregular input events delivery (#11817)" #12280
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er#11817)" (flutter#12251)" This reverts commit 3c6383f.
Because `Engine::Restart` changes `runtime_controller_`. This fixes flutter/flutter#40303
chinmaygarde
suggested changes
Sep 13, 2019
Contributor
chinmaygarde
left a comment
chinmaygarde
left a comment
There was a problem hiding this comment.
The runtime controller can die as a result of hot restarts and after resuming on Android (the Animator is fine as it's lifecycle is tied to that of the the engine). Caching the dispatcher now makes it hold a reference to a dead runtime controller. Please use delegation to make the engine intercept the call and have it check if there is a live runtime controller.
Contributor
Author
|
@chinmaygarde : delegate added. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 16, 2019
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Sep 16, 2019
git@github.com:flutter/engine.git/compare/2c4ed36c60ae...8a8610a git log 2c4ed36..8a8610a --no-merges --oneline 2019-09-16 liyuqian@google.com Implement Base32Decode (flutter/engine#12253) 2019-09-16 liyuqian@google.com Reland "Smooth out iOS irregular input events delivery (#11817)" (flutter/engine#12280) 2019-09-16 mouad.debbar@gmail.com Refactor and polish the 'felt' tool (flutter/engine#12258) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jimgraham@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
liyuqian
added a commit
to liyuqian/engine
that referenced
this pull request
Sep 20, 2019
…er#11817)" (flutter#12280)" This reverts commit aac33d1.
liyuqian
added a commit
that referenced
this pull request
Sep 20, 2019
…" (#12280)" (#12364) This reverts commit aac33d1. Reason: flutter/flutter#40863 TBR: chinmaygarde, iskakaushik
liyuqian
added a commit
to liyuqian/engine
that referenced
this pull request
Sep 22, 2019
This reverts commit c2879ca.
Inconnu08
pushed a commit
to Inconnu08/flutter
that referenced
this pull request
Sep 30, 2019
git@github.com:flutter/engine.git/compare/2c4ed36c60ae...8a8610a git log 2c4ed36..8a8610a --no-merges --oneline 2019-09-16 liyuqian@google.com Implement Base32Decode (flutter/engine#12253) 2019-09-16 liyuqian@google.com Reland "Smooth out iOS irregular input events delivery (flutter#11817)" (flutter/engine#12280) 2019-09-16 mouad.debbar@gmail.com Refactor and polish the 'felt' tool (flutter/engine#12258) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jimgraham@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
liyuqian
added a commit
that referenced
this pull request
Sep 30, 2019
) This reverts commit c2879ca. Additionally, we fix flutter/flutter#40863 by adding a secondary VSYNC callback. Unit tests are updated to provide VSYNC mocking and check the fix of flutter/flutter#40863. The root cause of having flutter/flutter#40863 is the false assumption that each input event must trigger a new frame. That was true in the framework PR flutter/flutter#36616 because the input events there are all scrolling move events. When the PR was ported to the engine, we can no longer distinguish different types of events, and tap events may no longer trigger a new frame. Therefore, this PR directly hooks into the `VsyncWaiter` and uses its (newly added) secondary callback to dispatch the pending input event.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additionally, we now use the engine directly as a delegate instead of storing potentially dead runtime_controller.
Unit tests have been updated to include an engine restart check which would fail before the fix.
This fixes flutter/flutter#40303