This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Revert "Revert "Roll src/third_party/dart a554c8be6b..d0052c1b31 (22 … #12291
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s)" (flutter#12290)" This reverts commit 3f76f55.
Contributor
Author
|
this reverts the revert cc: @chinmaygarde |
Contributor
Author
dnfield
approved these changes
Sep 15, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 16, 2019
…b31 (22 commits)" (flutter#12290)" (flutter/engine#12291)
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Sep 16, 2019
git@github.com:flutter/engine.git/compare/834cd15010b2...31e5149 git log 834cd15..31e5149 --no-merges --oneline 2019-09-16 iska.kaushik@gmail.com Revert "Revert "Roll src/third_party/dart a554c8be6b..d0052c1b31 (22 commits)" (#12290)" (flutter/engine#12291) 2019-09-16 iska.kaushik@gmail.com Revert "Add iOS platform view mutation XCUITests to the scenario app (#11652)" (flutter/engine#12292) 2019-09-15 ychris@google.com Add iOS platform view mutation XCUITests to the scenario app (flutter/engine#11652) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jimgraham@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Inconnu08
pushed a commit
to Inconnu08/flutter
that referenced
this pull request
Sep 30, 2019
git@github.com:flutter/engine.git/compare/834cd15010b2...31e5149 git log 834cd15..31e5149 --no-merges --oneline 2019-09-16 iska.kaushik@gmail.com Revert "Revert "Roll src/third_party/dart a554c8be6b..d0052c1b31 (22 commits)" (flutter#12290)" (flutter/engine#12291) 2019-09-16 iska.kaushik@gmail.com Revert "Add iOS platform view mutation XCUITests to the scenario app (flutter#11652)" (flutter/engine#12292) 2019-09-15 ychris@google.com Add iOS platform view mutation XCUITests to the scenario app (flutter/engine#11652) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jimgraham@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…commits)" (#12290)"
This reverts commit 3f76f55.