This repository was archived by the owner on Feb 25, 2025. It is now read-only.
delete golden files; switch to flutter/goldens #12434
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ditman
approved these changes
Sep 24, 2019
Member
ditman
left a comment
ditman
left a comment
There was a problem hiding this comment.
LGTM, only one minor comment about workflow that is not a one-way door at all :)
ditman
approved these changes
Sep 25, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 25, 2019
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Sep 25, 2019
git@github.com:flutter/engine.git/compare/48ad8a08e45f...0bfca37 git log 48ad8a0..0bfca37 --no-merges --oneline 2019-09-25 yjbanov@google.com Force exit felt tool on sigint, sigterm (flutter/engine#12443) 2019-09-25 skia-flutter-autoroll@skia.org Roll src/third_party/skia 6abaff3041a3..559ffe4a23ce (2 commits) (flutter/engine#12444) 2019-09-25 dworsham@google.com [fuchsia] Wire up OpacityLayer to Scenic (flutter/engine#11322) 2019-09-25 yjbanov@google.com delete golden files; switch to flutter/goldens (flutter/engine#12434) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC aaclarke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Inconnu08
pushed a commit
to Inconnu08/flutter
that referenced
this pull request
Sep 30, 2019
git@github.com:flutter/engine.git/compare/48ad8a08e45f...0bfca37 git log 48ad8a0..0bfca37 --no-merges --oneline 2019-09-25 yjbanov@google.com Force exit felt tool on sigint, sigterm (flutter/engine#12443) 2019-09-25 skia-flutter-autoroll@skia.org Roll src/third_party/skia 6abaff3041a3..559ffe4a23ce (2 commits) (flutter/engine#12444) 2019-09-25 dworsham@google.com [fuchsia] Wire up OpacityLayer to Scenic (flutter/engine#11322) 2019-09-25 yjbanov@google.com delete golden files; switch to flutter/goldens (flutter/engine#12434) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC aaclarke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.