Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@cyanglaz
Copy link
Contributor

Reland #11652 as the CI is ready.

@cyanglaz cyanglaz changed the title Reland Add iOS platform view mutation XCUITests to the scenario app(#11652) Reland "Add iOS platform view mutation XCUITests to the scenario app(#11652)" Sep 30, 2019
Copy link
Contributor

@iskakaushik iskakaushik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cyanglaz cyanglaz merged commit bf620dc into flutter:master Oct 1, 2019
@cyanglaz cyanglaz deleted the revert branch October 1, 2019 17:51
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 1, 2019
engine-flutter-autoroll added a commit to flutter/flutter that referenced this pull request Oct 1, 2019
git@github.com:flutter/engine.git/compare/5c428d924790...9e6314d

git log 5c428d9..9e6314d --no-merges --oneline
2019-10-01 bkonyi@google.com Roll src/third_party/dart 998f1efbe9..1103600280 (6 commits)
2019-10-01 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/linux-amd64 from 3Axx8... to L_AEL... (flutter/engine#12726)
2019-10-01 ychris@google.com Reland "Add iOS platform view mutation XCUITests to the scenario app(#11652)" (flutter/engine#12707)
2019-10-01 skia-flutter-autoroll@skia.org Roll src/third_party/skia a7914a872657..1e9112fbb472 (4 commits) (flutter/engine#12724)
2019-10-01 30870216+gaaclarke@users.noreply.github.com Resize channel buffers (flutter/engine#12402)
2019-10-01 bkonyi@google.com Roll src/third_party/dart fb1c5a6404..998f1efbe9 (3 commits)
2019-10-01 30870216+gaaclarke@users.noreply.github.com Cleanup: Turned on NS_ASSUME_NONNULL_BEGIN for FlutterViewController. (flutter/engine#12708)
2019-10-01 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from Jr7x0... to Q4sFH... (flutter/engine#12722)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC cbracken@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Inconnu08 pushed a commit to Inconnu08/flutter that referenced this pull request Nov 26, 2019
git@github.com:flutter/engine.git/compare/5c428d924790...9e6314d

git log 5c428d9..9e6314d --no-merges --oneline
2019-10-01 bkonyi@google.com Roll src/third_party/dart 998f1efbe9..1103600280 (6 commits)
2019-10-01 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/linux-amd64 from 3Axx8... to L_AEL... (flutter/engine#12726)
2019-10-01 ychris@google.com Reland "Add iOS platform view mutation XCUITests to the scenario app(flutter#11652)" (flutter/engine#12707)
2019-10-01 skia-flutter-autoroll@skia.org Roll src/third_party/skia a7914a872657..1e9112fbb472 (4 commits) (flutter/engine#12724)
2019-10-01 30870216+gaaclarke@users.noreply.github.com Resize channel buffers (flutter/engine#12402)
2019-10-01 bkonyi@google.com Roll src/third_party/dart fb1c5a6404..998f1efbe9 (3 commits)
2019-10-01 30870216+gaaclarke@users.noreply.github.com Cleanup: Turned on NS_ASSUME_NONNULL_BEGIN for FlutterViewController. (flutter/engine#12708)
2019-10-01 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from Jr7x0... to Q4sFH... (flutter/engine#12722)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC cbracken@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants