This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Build AOT and test targets, generate FARs when building Fuchsia #12761
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnfield
commented
Oct 3, 2019
tools/fuchsia/fuchsia_archive.gni
Outdated
| # Creates a package dir that we will them use pm to package. | ||
| # Creates a Fuchsia archive (.far) file using PM from the Fuchsia SDK. | ||
| # | ||
| # This currently ignores the CMX files and does minimal validation. |
Contributor
Author
There was a problem hiding this comment.
@iskakaushik does this need a TODO? Is it still even true?
Contributor
|
@dnfield don't we need to change the build_fuchsia python script to no longer invoke gen_package and other stuff? |
iskakaushik
reviewed
Oct 3, 2019
tools/fuchsia/fuchsia_archive.gni
Outdated
| deps = pkg_dir_deps + [ ":${target_name}_dir" ] | ||
| sources = copy_outputs | ||
| inputs = [ | ||
| "$flutter_root/tools/fuchsia/gather_flutter_runner_artifacts.py", |
Contributor
There was a problem hiding this comment.
shouldn't inputs be the same as inputs for package_dir
Contributor
Author
There was a problem hiding this comment.
This was neeeded because the gen_package script imported that. It's not needed anymore.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 4, 2019
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Oct 4, 2019
git@github.com:flutter/engine.git/compare/62e58c5d9fc2...2e163b2 git log 62e58c5..2e163b2 --no-merges --oneline 2019-10-04 dnfield@google.com Revert "Build AOT and test targets, generate FARs when building Fuchsia (#12761)" (flutter/engine#12781) 2019-10-03 30870216+gaaclarke@users.noreply.github.com Enabled people to chose if SystemNavigator.pop is animated on iOS. (flutter/engine#12752) 2019-10-03 30870216+gaaclarke@users.noreply.github.com Added some thread asserts to the code and made ios_surface_ safe since (flutter/engine#12775) 2019-10-03 dnfield@google.com Build AOT and test targets, generate FARs when building Fuchsia (flutter/engine#12761) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC liyuqian@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
dnfield
added a commit
to dnfield/engine
that referenced
this pull request
Oct 4, 2019
…ng Fuchsia (flutter#12761)" (flutter#12781)" This reverts commit 2e163b2.
Inconnu08
pushed a commit
to Inconnu08/flutter
that referenced
this pull request
Nov 26, 2019
git@github.com:flutter/engine.git/compare/62e58c5d9fc2...2e163b2 git log 62e58c5..2e163b2 --no-merges --oneline 2019-10-04 dnfield@google.com Revert "Build AOT and test targets, generate FARs when building Fuchsia (flutter#12761)" (flutter/engine#12781) 2019-10-03 30870216+gaaclarke@users.noreply.github.com Enabled people to chose if SystemNavigator.pop is animated on iOS. (flutter/engine#12752) 2019-10-03 30870216+gaaclarke@users.noreply.github.com Added some thread asserts to the code and made ios_surface_ safe since (flutter/engine#12775) 2019-10-03 dnfield@google.com Build AOT and test targets, generate FARs when building Fuchsia (flutter/engine#12761) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC liyuqian@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now my local workflow involves running 3 or 4 different scripts to achieve this - this is more analogous to what we do on other platforms, e.g. creating the flutter.jar and the test jar files when we build Android.
Since flutter_runner_tests and the relevant far are now built by default, we also don't need the shell script or the special step in CI to do it.
Once this lands, we can also simplify the LUCI recipe for Fuchsia related things that is trying to do similar work.