This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Upgrades the ICU version to 64.2 #13123
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@chinmaygarde @iskakaushik FYI I'll probably need some good advice on how to test this stuff out. |
chinmaygarde
approved these changes
Oct 14, 2019
filmil
force-pushed
the
upgrade-icu
branch
4 times, most recently
from
2139d39 to
1d88867
Compare
Contributor
Author
|
There was an intervening update to the licenses files in the meantime. Rebased, and will use the diff report from https://github.com/flutter/engine/tree/master/tools/licenses to merge the licenses correctly. I don't think I can do this manually. |
filmil
force-pushed
the
upgrade-icu
branch
7 times, most recently
from
7663a42 to
914cfd2
Compare
The current version is 62.1, which is a now 3 major releases behind, given that ICU 65 was released on Oct 3, 2019. The version bump required an update to buildroot to fix too strict compilation of ICU. Previous update was here: flutter#6097 I was advised to upgrade in the code review for this PR: flutter#13045 This change brings in the function `icu::Locale::forLanguageTag(...)` which is directly relevant to the work in the PR, but also updates the library considerably. Tested: ```bash set -x readonly FLUTTER_ENGINE_DIR="${FLUTTER_ENGINE_DIR:-$HOME/fx/flutter/engine/src}" readonly OUT_DIR="${FLUTTER_ENGINE_DIR}/out" ( cd ${FLUTTER_ENGINE_DIR} ./flutter/tools/gn --unoptimized ninja -j 100 -C "${OUT_DIR}/host_debug_unopt" ./flutter/testing/run_tests.py --type engine ) ```
Contributor
Author
|
@chinmaygarde All precommit hooks have passed. Is there anything else I need to do here? |
chinmaygarde
approved these changes
Oct 15, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current version is 62.1, which is a now 3 major releases behind,
given that ICU 65 was released on Oct 3, 2019.
The version bump required an update to buildroot to fix too strict compilation
of ICU.
Previous update was here:
#6097
I was advised to upgrade in the code review for this PR:
#13045
This change brings in the function
icu::Locale::forLanguageTag(...)which is directly relevant to the work in the PR, but also updates
the library considerably.
Tested: