This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[web] Fix Edge detection for correct dom_renderer reset #13940
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nturgut
reviewed
Nov 20, 2019
|
|
||
| switch (browserEngine) { | ||
| case BrowserEngine.blink: | ||
| case BrowserEngine.edge: |
Contributor
There was a problem hiding this comment.
I checked it.
(1) if the Browser is Edge and OS is IOS then the engine is Webkit. (Otherwise always blink)
(2) If browser is older than earlier 2019 it is not blink.
nturgut
approved these changes
Nov 20, 2019
Contributor
nturgut
left a comment
nturgut
left a comment
There was a problem hiding this comment.
Thanks Ferhat. I added a comment for the switch statement. In my opinion we might also want to check the OS. So that if anyone uses Edge on IOS they can still use text editing. We have a major branch in the code for OS=IOS Engine=Webkit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 21, 2019
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Nov 21, 2019
git@github.com:flutter/engine.git/compare/176f56329631...6bf311f git log 176f563..6bf311f --no-merges --oneline 2019-11-20 bkonyi@google.com Roll src/third_party/dart b188632458..867a6e0e52 (4 commits) (flutter/engine#13948) 2019-11-20 gw280@google.com Ensure we use the base CompositorContext's AcquireFrame method when screenshotting (flutter/engine#13934) 2019-11-20 chinmaygarde@google.com Update SwiftShader to 5d1e854. (flutter/engine#13945) 2019-11-20 ianloic@google.com [flutter_runner] fix a11y tests (flutter/engine#13947) 2019-11-20 bkonyi@google.com Roll src/third_party/dart 8342ec2c71..b188632458 (2 commits) (flutter/engine#13942) 2019-11-20 ferhat@gmail.com Fix edge detection for correct dom_renderer reset (flutter/engine#13940) 2019-11-20 bkonyi@google.com Roll src/third_party/dart 1f933abcee..8342ec2c71 (12 commits) (flutter/engine#13941) 2019-11-20 50856934+nturgut@users.noreply.github.com [web] Flutter for web autocorrect support (flutter/engine#13922) 2019-11-20 skia-flutter-autoroll@skia.org Roll src/third_party/skia e678b79c489d..935a35d972e5 (13 commits) (flutter/engine#13927) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC aaclarke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Edge crash on app startup due -moz-selection insertion in dom_renderer.
Fixes: flutter/flutter#45162