This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Started allowing setting message handlers to nil for dead engines #18428
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
that aren't running.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 16, 2020
wandyers
pushed a commit
to wandyers/engine
that referenced
this pull request
May 23, 2020
13 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue: flutter/flutter#57151
related issue: flutter/flutter#56996
Plugins who attempt to nil out their channels when getting detached from a dying engine are running afoul of this assert. We can make this acceptable or find someway to pass the context to a plugin to know wether it is detaching from a dying engine or a running engine. I opted for the former.