This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Fix unoptimized fuchsia builds #20488
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dreveman
approved these changes
Aug 13, 2020
chinmaygarde
approved these changes
Aug 13, 2020
Contributor
chinmaygarde
left a comment
chinmaygarde
left a comment
There was a problem hiding this comment.
LGTM but have we considered not having to import the internal utils header? I believe that is only necessary for dart::GetComponentContext. That is a private header and no other target includes it so its a bit weird that some Fuchsia targets need the same.
Contributor
Author
I tried removing that header as a first attempt and it is kinda difficult. |
This was referenced Aug 14, 2020
This was referenced Aug 14, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#20459 caused this to regress
This fix is more robust, and will hopefully last longer