This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Add C++ based support for drawAtlas #220
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eseidelGoogle
force-pushed
the
atlas
branch
2 times, most recently
from
c4ea96a to
e73b571
Compare
Contributor
Author
|
This should be ready for review @abarth. We'll turn it on once we have a chance to verify that it's 100% correct. |
Contributor
|
Lgtm |
This is supposed to make Viktor's game faster, but it's not clear to me that it actually does. I've left the code using the dart version of drawAtlas for now until Viktor can verify that it looks correct. I also added a wrapper for SkFilterQuality in the process of debugging SkCanvas.drawAtlas since all drawAtlas examples in Skia use FilterQuality.low. The bug which blocked me for so long turned out to be that SkCanvas.drawAtlas doesn't draw anything if antialiasing is turned on. Issue #138. R=abarth@google.com
eseidelGoogle
added a commit
that referenced
this pull request
Jul 23, 2015
Add C++ based support for drawAtlas
rhencke
pushed a commit
to rhencke/engine
that referenced
this pull request
Dec 20, 2020
Move License to root directory
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is supposed to make Viktor's game faster, but it's not clear
to me that it actually does.
I think I'm seeing the framerate during explosions go from
the current 16fps to 20fps after my change, but it's not entirely
clear. We need to do some better profiling. I've left the code
using the dart version of drawAtlas for now until Viktor can
verify that it looks correct.
Issue #138.
R=abarth@google.com