This repository was archived by the owner on Feb 25, 2025. It is now read-only.
iOS build is now closer to the Android and Linux builds. Correctly builds the dart-pkg/packages files so that you don't have to build the Android build to run sky_server. #222
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@abarth is your best reviewer, but this lgtm. |
Contributor
|
LGTM except for the demo launcher line in dist/BUILD.gn. that shouldn't be needed on ios |
Android and Linux builds. Also fixes a couple of toolchain selection issues.
iansf
added a commit
that referenced
this pull request
Jul 23, 2015
iOS build is now closer to the Android and Linux builds. Correctly builds the dart-pkg/packages files so that you don't have to build the Android build to run sky_server.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.