Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@vlidholt
Copy link
Contributor

Custom play button drawn with a Texture, up and down state.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

width and height should be here too

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also since you support changing the texture on the fly here you should probably change the token here too.

@vlidholt
Copy link
Contributor Author

Thanks! Will fix

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you shouldn't need this. the superclass sets it to false by default.

@Hixie
Copy link
Contributor

Hixie commented Jul 23, 2015

LGTM!

vlidholt added a commit that referenced this pull request Jul 23, 2015
Adds custom play button with texture to demo game
@vlidholt vlidholt merged commit f76a56d into flutter:master Jul 23, 2015
rhencke pushed a commit to rhencke/engine that referenced this pull request Dec 20, 2020
rhencke pushed a commit to rhencke/engine that referenced this pull request Dec 20, 2020
Remove the extra 1 (field name) from generated field paths, so they refer to the whole field rather than the name.

Add missing proto message field metadata to the Dart proto generator (attached to setter/getter/has/clear methods). Fix a bug with indented space counting, which would cause all indented fields to use the incorrect count (off by the size of the indent).

Add metadata to the unnamed constructors in the generated dart proto files. Also removed extra list copy constructor calls when the field path isn't being modified. The named constructors (e.g. fromJson) don't need this because, at the call site, the class name and the constructor name are two separate links.
WonyoungChoi pushed a commit to WonyoungChoi/engine that referenced this pull request Dec 23, 2021
Signed-off-by: Boram Bae <boram21.bae@samsung.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants