This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Feedback from previous logging code review that I missed. #225
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
lgtm |
Contributor
|
Thanks! I filed https://github.com/domokit/sky_engine/issues/224 about this issue. |
iansf
added a commit
that referenced
this pull request
Jul 23, 2015
Feedback from previous logging code review that I missed.
Contributor
Author
|
Closes #224 |
rhencke
pushed a commit
to rhencke/engine
that referenced
this pull request
Dec 20, 2020
automate updating the docs
rhencke
pushed a commit
to rhencke/engine
that referenced
this pull request
Dec 20, 2020
…r#225) This change brings Dart closer in line to other languages like Java, which already generate this annotation for proto fields which have been deprecated.
WonyoungChoi
pushed a commit
to WonyoungChoi/engine
that referenced
this pull request
Dec 23, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.