This repository was archived by the owner on Feb 25, 2025. It is now read-only.
RenderConstrainedBox was ignoring its additional constraints for its intrinsic size logic when it had no child #234
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…intrinsic size logic when it had no child.
Contributor
|
LGTM |
Hixie
added a commit
that referenced
this pull request
Jul 23, 2015
RenderConstrainedBox was ignoring its additional constraints for its intrinsic size logic when it had no child
Contributor
Author
|
@HansMuller This should fix the issue you were seeing. |
abarth
added a commit
to abarth/engine
that referenced
this pull request
Nov 20, 2015
Previously, we tried to use the render tree's paint offset to move the text to the proper position, but that appears to snap to integer logical pixels, introducing jitter. Now we use the SkCanvas's matrix to position the text, removing the jitter. Fixes flutter#234
miguelfrde
pushed a commit
to miguelfrde/engine
that referenced
this pull request
Jan 7, 2020
- Respect TERM=dumb (don't print colors) - Kill child processes properly if the roller is stopped - Unbuffer output for better logging - Allow for skipping the creation of a pull request - Other mysterious features and bug fixes!
rhencke
pushed a commit
to rhencke/engine
that referenced
this pull request
Dec 20, 2020
upgrade grinder to 0.7.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.