This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[web] Fix shadow rendering using boxshadow due to webkit repaint area bug #23769
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hen using filter CSS attribute
yjbanov
approved these changes
Jan 19, 2021
| /// Returns a color for box-shadow based on blur filter at sigma. | ||
| ui.Color blurColor(ui.Color color, double sigma) { | ||
| final double strength = math.max(math.min( | ||
| math.sqrt(sigma) / (math.pi * 2.0), 1.0), 0.0); |
Contributor
There was a problem hiding this comment.
Do we need math.max? Presumably sigma is >= 0, and so math.min(math.sqrt(sigma) / (math.pi * 2.0), 1.0) is also >= 0.
| } | ||
| await canvasScreenshot(rc, 'dom_mask_filter_blur', | ||
| region: screenRect, | ||
| maxDiffRatePercent: 0.01); |
Contributor
Author
There was a problem hiding this comment.
blur & gradients typically are slightly off between mac and linux.
ferhatb
added
the
waiting for tree to go green
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 20, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 20, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 20, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 20, 2021
hjfreyer
pushed a commit
to hjfreyer/engine
that referenced
this pull request
Mar 22, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Webkit fails to repaint correct area when filter: blur is used on a dom node.
This PR switches Dom rendering of blurred rectangles to use box shadow instead for webkit.
Related Issues
flutter/flutter#71835
Tests
Added dom_mask_filter test.
Pre-launch Checklist
writing and running engine tests.
///).