This repository was archived by the owner on Feb 25, 2025. It is now read-only.
WIP: Add TextInput.setMarkedTextRect handler for Windows #23789
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When inputting text via multi-step text input, such as via Chinese,
Japanese, or Korean IME input methods, the framework computes the
rectangle of the compose text and updates the embedder via the
TextInput.setMarkedTextRect message over the channel.
We add a handler for this method which stores the composing rect as a
field on TextInputPlugin.
In a followup patch, a similar handler will be added for the
TextInput.setEditableSizeAndTransform message. Them when compose rect is
needed in window coordinates, the rect can be multipled by the 4x4
transform matrix, so the result may be fetched by the view/window class
and the IME candidates window position updated.
Issues
This is one in a series of patches addressing flutter/flutter#65574: Full IME support for Windows
Pre-launch Checklist
writing and running engine tests.
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.