Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[web] Add samsung browser detection #25198

Merged
ferhatb merged 4 commits into from
Mar 25, 2021
Merged

[web] Add samsung browser detection #25198

ferhatb merged 4 commits into from
Mar 25, 2021

Conversation

@ferhatb
Copy link
Contributor

@ferhatb ferhatb commented Mar 23, 2021

Update browser engine detection.

Related to fix for flutter/flutter#76930

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides].
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See [testing the engine] for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the [CLA].
  • All existing and new tests are passing.
  • The reviewer has submitted any presubmit flakes in this PR using the [engine presubmit flakes form] before re-triggering the failure.

@ferhatb ferhatb requested a review from mdebbar March 23, 2021 19:07
@google-cla google-cla bot added the cla: yes label Mar 23, 2021
mdebbar
mdebbar approved these changes Mar 23, 2021
View reviewed changes
Copy link
Contributor

@mdebbar mdebbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I like the tests!

@ferhatb ferhatb merged commit afab588 into flutter:master Mar 25, 2021
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 25, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 25, 2021
@engine-flutter-autoroll
afab588 [web] Add samsung browser detection (flutter/engine#25198)
4e322b2
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 25, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 25, 2021
@engine-flutter-autoroll
afab588 [web] Add samsung browser detection (flutter/engine#25198)
a636ec9
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 26, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 26, 2021
@engine-flutter-autoroll
afab588 [web] Add samsung browser detection (flutter/engine#25198)
9e1b09c
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 26, 2021
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 26, 2021
@engine-flutter-autoroll
afab588 [web] Add samsung browser detection (flutter/engine#25198)
d98028e
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 29, 2021
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 29, 2021
@engine-flutter-autoroll
afab588 [web] Add samsung browser detection (flutter/engine#25198)
28e08bc
chandarrengoog pushed a commit to chandarrengoog/engine that referenced this pull request Mar 30, 2021
@ferhatb @chandarrengoog
[web] Add samsung browser detection (flutter#25198)
11da35d
duanqz pushed a commit to duanqz/engine that referenced this pull request Apr 16, 2021
@ferhatb @duanqz
[web] Add samsung browser detection (flutter#25198)
8582788
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@mdebbar mdebbar mdebbar approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ferhatb @mdebbar