Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

started cleaning scenario tests before running them #25222

Merged
fluttergithubbot merged 1 commit into from
Mar 25, 2021
Merged

started cleaning scenario tests before running them #25222

fluttergithubbot merged 1 commit into from
Mar 25, 2021

Conversation

@gaaclarke
Copy link
Member

@gaaclarke gaaclarke commented Mar 24, 2021 •
edited
Loading

Because of the weird tricks that are happening to make scenario app tests work I ran into problems where they were running locally with old versions of the engine. Cleaning out the test before hand seems to have solved the issue for me.

related issue: flutter/flutter#78907

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.
  • The reviewer has submitted any presubmit flakes in this PR using the engine presubmit flakes form before re-triggering the failure.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@gaaclarke gaaclarke requested a review from jmagman March 24, 2021 18:51
@google-cla google-cla bot added the cla: yes label Mar 24, 2021
jmagman
jmagman approved these changes Mar 24, 2021
View reviewed changes
Copy link
Member

@jmagman jmagman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gaaclarke gaaclarke added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Mar 24, 2021
@fluttergithubbot fluttergithubbot merged commit 8a09fd2 into flutter:master Mar 25, 2021
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 25, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 25, 2021
@engine-flutter-autoroll
8a09fd2 started cleaning scenario tests before running them (flutter/…
25f1b99 
…engine#25222)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 25, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 25, 2021
@engine-flutter-autoroll
8a09fd2 started cleaning scenario tests before running them (flutter/…
ae4b4c3 
…engine#25222)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 25, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 25, 2021
@engine-flutter-autoroll
8a09fd2 started cleaning scenario tests before running them (flutter/…
408d0f0 
…engine#25222)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 26, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 26, 2021
@engine-flutter-autoroll
8a09fd2 started cleaning scenario tests before running them (flutter/…
59457cc 
…engine#25222)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 26, 2021
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 26, 2021
@engine-flutter-autoroll
8a09fd2 started cleaning scenario tests before running them (flutter/…
3bd7ab8 
…engine#25222)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 29, 2021
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 29, 2021
@engine-flutter-autoroll
8a09fd2 started cleaning scenario tests before running them (flutter/…
aa1a981 
…engine#25222)
chandarrengoog pushed a commit to chandarrengoog/engine that referenced this pull request Mar 30, 2021
@gaaclarke @chandarrengoog
started cleaning scenario tests before running them (flutter#25222)
1880986
duanqz pushed a commit to duanqz/engine that referenced this pull request Apr 16, 2021
@gaaclarke @duanqz
started cleaning scenario tests before running them (flutter#25222)
f985a7a
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@jmagman jmagman jmagman approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gaaclarke @jmagman @fluttergithubbot