Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Fix iOS key events in platform views #25365

Closed
KammererTob wants to merge 10 commits into from
Closed

Fix iOS key events in platform views #25365

Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
8e212dd
added keyevent support for iOS
KammererTob Sep 1, 2020
068bb22
formatting and version check fix
KammererTob Sep 3, 2020
743c9e9
ignored unused press phases
KammererTob Sep 8, 2020
0dd3671
Merge branch 'master' of github.com:flutter/engine
KammererTob Sep 8, 2020
e355ad1
Merge branch 'master' of github.com:flutter/engine
KammererTob Oct 13, 2020
c3ef1fe
Merge branch 'master' of github.com:flutter/engine
KammererTob Oct 17, 2020
285b6c8
added tests
KammererTob Oct 17, 2020
c44c8c1
fixed compile errors
KammererTob Oct 17, 2020
aec44ba
Merge branch 'master' of github.com:flutter/engine
KammererTob Mar 21, 2021
7e9390f
Fix for platform views not receiving key events
KammererTob Mar 21, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions shell/platform/darwin/ios/framework/Source/FlutterViewController.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1096,26 +1096,33 @@ - (void)dispatchPresses:(NSSet<UIPress*>*)presses API_AVAILABLE(ios(13.4)) {
}
}

- (void)pressesBegan:(NSSet<UIPress*>*)presses withEvent:(UIEvent*)event API_AVAILABLE(ios(9.0)) {
- (void)pressesBegan:(NSSet<UIPress*>*)presses
withEvent:(UIPressesEvent*)event API_AVAILABLE(ios(9.0)) {
[super pressesBegan:presses withEvent:event];
if (@available(iOS 13.4, *)) {
[self dispatchPresses:presses];
}
}

- (void)pressesChanged:(NSSet<UIPress*>*)presses withEvent:(UIEvent*)event API_AVAILABLE(ios(9.0)) {
- (void)pressesChanged:(NSSet<UIPress*>*)presses
withEvent:(UIPressesEvent*)event API_AVAILABLE(ios(9.0)) {
[super pressesChanged:presses withEvent:event];
if (@available(iOS 13.4, *)) {
[self dispatchPresses:presses];
}
}

- (void)pressesEnded:(NSSet<UIPress*>*)presses withEvent:(UIEvent*)event API_AVAILABLE(ios(9.0)) {
- (void)pressesEnded:(NSSet<UIPress*>*)presses
withEvent:(UIPressesEvent*)event API_AVAILABLE(ios(9.0)) {
[super pressesEnded:presses withEvent:event];
if (@available(iOS 13.4, *)) {
[self dispatchPresses:presses];
}
}

- (void)pressesCancelled:(NSSet<UIPress*>*)presses
withEvent:(UIEvent*)event API_AVAILABLE(ios(9.0)) {
withEvent:(UIPressesEvent*)event API_AVAILABLE(ios(9.0)) {
[super pressesCancelled:presses withEvent:event];
if (@available(iOS 13.4, *)) {
[self dispatchPresses:presses];
}
Expand Down