This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Add sky_services pub package #254
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This package contains the mojom.dart files we generate from the sky_engine repository.
Contributor
|
Will this eventually contain the binaries (.jar, etc.) to support those services as well? @johnmccutchan |
Contributor
|
Does this mean we no longer need to depend on the mojom package? lgtm |
Contributor
Author
|
I think we still need the mojom package to give a canonical name to these interfaces. Putting the jars in here is an interesting idea. That could make a lot of sense. |
miguelfrde
pushed a commit
to miguelfrde/engine
that referenced
this pull request
Jan 7, 2020
We now have BUILD.gn files for libc++ and libc++abi, and the toolchain includes 32-bit versions of libc++ and libc++abi anyway.
rhencke
pushed a commit
to rhencke/engine
that referenced
this pull request
Dec 20, 2020
…utter#254) An upcoming change to the Dart SDK will change `HttpRequest` and `HttpClientResponse` from implementing `Stream<List<int>>` to implementing `Stream<Uint8List>`. This forwards-compatible change prepares for that SDK breaking change by casting the Stream to `List<int>` before transforming it. dart-lang/sdk#36900
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This package contains the mojom.dart files we generate from the sky_engine
repository.