This repository was archived by the owner on Feb 25, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6k
Migrate third_party/expat dependency to googlecode #25683
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
This is dependent on flutter/buildroot#445 landing (at which point the buildroot SHA will need to be updated). |
third_party/expat was recently migrated from flutter/buildroot to our googlesource repo at https://flutter.googlesource.com/third_party/expat in [1] and deleted from the buildroot in [2]. This rolls the buildroot and adds the new upstream dependency. [1] https://flutter-review.googlesource.com/c/third_party/expat/+/12700 [2] flutter/buildroot#445 Bug: flutter/flutter#39532
Member
Author
|
Now that flutter/buildroot#445 has landed, this has been updated. |
jason-simmons
approved these changes
Apr 20, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 21, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 21, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 21, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 21, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 21, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 21, 2021
GuoXi
pushed a commit
to GuoXi/engine
that referenced
this pull request
Apr 25, 2021
third_party/expat was recently migrated from flutter/buildroot to our googlesource repo at https://flutter.googlesource.com/third_party/expat in [1] and deleted from the buildroot in [2]. This rolls the buildroot and adds the new upstream dependency. [1] https://flutter-review.googlesource.com/c/third_party/expat/+/12700 [2] flutter/buildroot#445 Bug: flutter/flutter#39532
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
third_party/expat was recently migrated from flutter/buildroot to our
googlesource repo at https://flutter.googlesource.com/third_party/expat
in [1] and deleted from the buildroot in [2]. This rolls the buildroot
and adds the new upstream dependency.
[1] https://flutter-review.googlesource.com/c/third_party/expat/+/12700
[2] flutter/buildroot#445
Bug: flutter/flutter#39532
Pre-launch Checklist
writing and running engine tests.
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.