Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@cbracken
Copy link
Member

third_party/expat was recently migrated from flutter/buildroot to our
googlesource repo at https://flutter.googlesource.com/third_party/expat
in [1] and deleted from the buildroot in [2]. This rolls the buildroot
and adds the new upstream dependency.

[1] https://flutter-review.googlesource.com/c/third_party/expat/+/12700
[2] flutter/buildroot#445

Bug: flutter/flutter#39532

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.
  • The reviewer has submitted any presubmit flakes in this PR using the engine presubmit flakes form before re-triggering the failure.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@cbracken
Copy link
Member Author

cbracken commented Apr 20, 2021

This is dependent on flutter/buildroot#445 landing (at which point the buildroot SHA will need to be updated).

third_party/expat was recently migrated from flutter/buildroot to our
googlesource repo at https://flutter.googlesource.com/third_party/expat
in [1] and deleted from the buildroot in [2]. This rolls the buildroot
and adds the new upstream dependency.

[1] https://flutter-review.googlesource.com/c/third_party/expat/+/12700
[2] flutter/buildroot#445

Bug: flutter/flutter#39532
@cbracken
Copy link
Member Author

Now that flutter/buildroot#445 has landed, this has been updated.

@cbracken cbracken merged commit 14f75d1 into flutter:master Apr 20, 2021
@cbracken cbracken deleted the roll-buildroot-expat branch April 20, 2021 23:16
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 21, 2021
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 21, 2021
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 21, 2021
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 21, 2021
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 21, 2021
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 21, 2021
GuoXi pushed a commit to GuoXi/engine that referenced this pull request Apr 25, 2021
third_party/expat was recently migrated from flutter/buildroot to our
googlesource repo at https://flutter.googlesource.com/third_party/expat
in [1] and deleted from the buildroot in [2]. This rolls the buildroot
and adds the new upstream dependency.

[1] https://flutter-review.googlesource.com/c/third_party/expat/+/12700
[2] flutter/buildroot#445

Bug: flutter/flutter#39532
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants