This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Windows keyboard integration tests and fix a number of issues #27921
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/engine into win-keyboard-unittests
dkwingsmt
changed the title
gspencergoog
approved these changes
Aug 11, 2021
| WM_KEYDOWN, 0, false, false), | ||
| true); | ||
| EXPECT_EQ(handler.KeyboardHook(nullptr, VK_LMENU, kScanCodeAltLeft, | ||
| EXPECT_EQ(handler.KeyboardHook(nullptr, VK_RMENU, kScanCodeAltLeft, |
Contributor
There was a problem hiding this comment.
Were these just all using the wrong side of the keyboard?
Contributor
Author
There was a problem hiding this comment.
Kind of. Previously the code that resolves side does not work very well and will send LMENU when right alt is pressed.
Co-authored-by: Greg Spencer <gspencergoog@users.noreply.github.com>
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 11, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 12, 2021
8 tasks
|
In portuguese when use accents the application close. test with áéãõâô |
Contributor
Author
Sorry about the crash. Can you file an issue on flutter/flutter for tracking? |
Ok, added, thanks for your attention |
filmil
pushed a commit
to filmil/engine
that referenced
this pull request
Apr 21, 2022
…r#27921) * Basic changes * Fix build * Revert some changes * Fix tests (ATP) * Win32Message and inject messagelist * wm builders * Format * Correct * LowerCaseAUnhandled * ShiftLeftKeyA * Ctrl-A * Ctrl-1 * Digit1OnFrenchLayout * AltGrKeyQ * Dead key E * ^1 * Multibyte * Format * License * Revert key.dart * Move CreateKeyEventLparam * MockEmbedderApiForKeyboard * More MockEmbedderApiForKeyboard * Doc * Move MockMessageQueue * is_deadchar doesnt seem needed * ConvertChar32ToUtf8 * PeekNextMessageType * Format * Apply suggestions from code review Co-authored-by: Greg Spencer <gspencergoog@users.noreply.github.com> Co-authored-by: Greg Spencer <gspencergoog@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes several issues related to Win32 Keyboard:
PeekMessage.The PR also covers some new use cases, such as:
This PR also adds an "integration test" for the Win32 keyboard system, taking the
Win32Window,KeyboardKeyHandler,TextInputPlugin, andKeyboardKeyEmbedderHandler. This is because, due to reasons explained in flutter/flutter#88021, the current single-class unit tests no longer provide us enough guarantee how a key press actually works. The "integration test" is also a preparation for a possible rework in the future that is explained in flutter/flutter#88021.This PR implements
WmBuilders to simulate precise Win32 messages for keyboard unit tests, and implementedMockMessageQueue, simulating a message queue that supportsPeekMessage.Pre-launch Checklist
writing and running engine tests.
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.