This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[web] Fix disposal of browser history on hot restart #28805
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chunhtai
approved these changes
Sep 22, 2021
Contributor
chunhtai
left a comment
chunhtai
left a comment
There was a problem hiding this comment.
LGTM, with some comments
|
|
||
| @override | ||
| Future<void> tearDown() async { | ||
| if (_isDisposed || urlStrategy == null) { |
Contributor
There was a problem hiding this comment.
I am not sure whether this will be a problem or not. If the browserhistory is disposed, it can't be teardown because this check.
Contributor
Author
There was a problem hiding this comment.
Nice catch! Let me use a separate boolean _isTornDown.
| // TODO(mdebbar): https://github.com/flutter/flutter/issues/50836 | ||
| skip: browserEngine == BrowserEngine.edge); | ||
|
|
||
| test('disposes of its listener without touching history', () async { |
Contributor
Author
There was a problem hiding this comment.
They are slightly different. One for single entry and one for multi entry.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 23, 2021
fluttergithubbot
pushed a commit
to flutter/flutter
that referenced
this pull request
Sep 23, 2021
clocksmith
pushed a commit
to clocksmith/flutter
that referenced
this pull request
Oct 29, 2021
|
Hi. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we don't dispose of
BrowserHistoryinstances, they keep listening topopstateevents even after a hot restart. So we end up with duplicate listeners.In this PR, we make sure to always dispose of
BrowserHistoryinstance but without resetting the browser history entries (to keep the effect of this PR).Fixes flutter/flutter#90031
Fixes flutter/flutter#83864