This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Linux, Embedder] Add engine restart hooks #28924
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkwingsmt
added
the
waiting for tree to go green
Contributor
|
This pull request is not suitable for automatic merging in its current state. |
fluttergithubbot
removed
the
waiting for tree to go green
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 29, 2021
6 tasks
akbiggs
pushed a commit
to akbiggs/engine
that referenced
this pull request
Oct 1, 2021
* Restart * Format * Doc * Test * Format * Revert keyboard
dnfield
pushed a commit
to dnfield/engine
that referenced
this pull request
Oct 6, 2021
* Restart * Format * Doc * Test * Format * Revert keyboard
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a hook to
FlutterProjectArgsand the linux embedding that is invoked when the engine restarts. This hook is typically invoked upon hot restarts (Shift-Rduring a Flutter CLI), and can be used to reset various states.This is a prerequisite to https://github.com/flutter/engine/pull/28877/files and fixing flutter/flutter#89729.
Pre-launch Checklist
writing and running engine tests.
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.