-
Notifications
You must be signed in to change notification settings - Fork 6k
Update functions to be consistent with other code. #29176
Update functions to be consistent with other code. #29176
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
80e076e to
5e9c794
Compare
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
cbracken
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
b1a8771 to
2962099
Compare
5e9c794 to
077176a
Compare
|
This pull request is not suitable for automatic merging in its current state.
|
Helper functions first, then callbacks/implementations, then public functions. Add function comments. Use consistent function naming. Remove unnecessary protoypes. Make a function static that wasn't.
077176a to
d644bda
Compare
Helper functions first, then callbacks/implementations, then public functions.
Add function comments.
Use consistent function naming.
Remove unnecessary protoypes.
Make a function static that wasn't.
Pre-launch Checklist
writing and running engine tests.
///).