This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Use Fuchsia's Windows Clang SDK #29736
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ment that C-compatible types be used when aliasing anonymous structs
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 15, 2021
Member
|
Awesome! Thanks @bdero -- it's been a very long time we've been excited about getting to this point! |
Member
Author
|
In case anyone wants to get the Fuchsia toolchain's clangd working on Windows, I documented it here (and needed to write a simple tool to unroll clang response files): https://gist.github.com/bdero/5950e8ad4e4234a548374a0d2f20f230#gistcomment-3966053 |
Contributor
|
This appears to break (at least some) Windows clients. See flutter/flutter#94580 (comment) |
Member
Author
|
@gspencergoog A roller was deployed recently for this. Can you try syncing to the version before the most recent windows clang SDK roll? #29988 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had a desire to use an accurate clangd among other common tools while debugging some things on Windows, so since the upstream bug referenced in DEPS is closed, I tried switching to the Fuchsia Clang SDK distribution to great effect.
This starts us off at the current integration label for the cipd package, but see the autoroller PR below.