This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[fuchsia] Fixes the HID usage handling #29815
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filmil
force-pushed
the
fix-hid-usage-nov18
branch
3 times, most recently
from
02ec379 to
6d1c53c
Compare
The old code stripped the USB hid usage page value from the Fuchsia key. It shouldn't be doing that. This change fixes the issue, and adds tests that rely on the key constants to verify that the change indeed does what it is supposed to do. In the process of fixing this, filed a few known issues and marked them as TODO. These issues should be handled in separate PRs. Fixes: flutter/flutter#93890
filmil
force-pushed
the
fix-hid-usage-nov18
branch
from
6d1c53c to
706a90e
Compare
arbreng
approved these changes
Nov 29, 2021
arbreng
added
the
waiting for tree to go green
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 30, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old code stripped the USB hid usage page value from the Fuchsia
key. It shouldn't be doing that. This change fixes the issue,
and adds tests that rely on the key constants to verify that the
change indeed does what it is supposed to do.
Fixes: flutter/flutter#93890
Pre-launch Checklist
writing and running engine tests.
///).