Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Add a comment in Image.toByteData to limit more encoders #29962

Merged
fluttergithubbot merged 2 commits into from
Nov 30, 2021
Merged

Add a comment in Image.toByteData to limit more encoders #29962

fluttergithubbot merged 2 commits into from
Nov 30, 2021

Conversation

@eggfly
Copy link
Member

@eggfly eggfly commented Nov 27, 2021 •
edited
Loading

And besides I found these issues and discussions are related to Image.toByteData:

I left documents and comments in the toByteData() API, indicating that this API is convergent, and when developers need more image formats, please use the third-party image library.

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides].
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See [testing the engine] for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the [CLA].
  • All existing and new tests are passing.

@flutter-dashboard flutter-dashboard bot added the platform-web Code specifically for the web engine label Nov 27, 2021
@google-cla google-cla bot added the cla: yes label Nov 27, 2021
@eggfly eggfly force-pushed the more_image_encoding_formats branch 3 times, most recently from cc395ae to 0993530 Compare November 29, 2021 02:57
@eggfly eggfly changed the title Support encoding to jpeg and webp in ui.Image Support encoding quality and encoding to jpeg and webp in ui.Image Nov 29, 2021
@eggfly eggfly force-pushed the more_image_encoding_formats branch 4 times, most recently from 4a4cae3 to 4c6f6ca Compare November 29, 2021 06:52
@eggfly
Copy link
Member Author

eggfly commented Nov 29, 2021

@dnfield @tvolkert @gaaclarke please take a short review 😄 thank u.

dnfield
dnfield suggested changes Nov 29, 2021
View reviewed changes
Copy link
Contributor

@dnfield dnfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this has been discussed before. We would rather not have to ship additional encoders.

@eggfly
Copy link
Member Author

eggfly commented Nov 29, 2021 •
edited
Loading

I think this has been discussed before. We would rather not have to ship additional encoders.

@dnfield Or I just added a single line comment for developers, guiding to use third-party image library? Otherwise the encoder is still continuing in issues page.

@eggfly eggfly force-pushed the more_image_encoding_formats branch from 4c6f6ca to 21da423 Compare November 29, 2021 07:38
@eggfly eggfly changed the title Support encoding quality and encoding to jpeg and webp in ui.Image Add a comment in Image.toByteData to limit more encoders Nov 29, 2021
@flutter-dashboard
Copy link

flutter-dashboard bot commented Nov 29, 2021

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@eggfly
Copy link
Member Author

eggfly commented Nov 29, 2021

@dnfield I change the goal of this PR, please review again~

@eggfly eggfly requested a review from dnfield November 29, 2021 09:34
tvolkert
tvolkert reviewed Nov 29, 2021
View reviewed changes
Copy link
Contributor

@tvolkert tvolkert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feels more appropriate as a code comment and not a dartdoc comment.

tvolkert
tvolkert reviewed Nov 29, 2021
View reviewed changes
@eggfly eggfly force-pushed the more_image_encoding_formats branch from 21da423 to 16bc064 Compare November 30, 2021 03:55
@eggfly eggfly requested a review from tvolkert November 30, 2021 04:00
tvolkert
tvolkert reviewed Nov 30, 2021
View reviewed changes
Copy link
Contributor

@tvolkert tvolkert left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you still change these to // comments instead of /// comments? Thanks!

@eggfly eggfly force-pushed the more_image_encoding_formats branch from 16bc064 to ef0534c Compare November 30, 2021 04:32
@eggfly
Copy link
Member Author

eggfly commented Nov 30, 2021

Can you still change these to // comments instead of /// comments? Thanks!

Sorry, I forgot that. Should I put my // comments under the /// dartdoc?

@eggfly eggfly requested a review from tvolkert November 30, 2021 04:34
dnfield
dnfield approved these changes Nov 30, 2021
View reviewed changes
Copy link
Contributor

@dnfield dnfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

tvolkert
tvolkert approved these changes Nov 30, 2021
View reviewed changes
Copy link
Contributor

@tvolkert tvolkert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dnfield dnfield added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Nov 30, 2021
@fluttergithubbot
Copy link
Contributor

fluttergithubbot commented Nov 30, 2021

This pull request is not suitable for automatic merging in its current state.

  • The status or check suite Linux Fuchsia has failed. Please fix the issues identified (or deflake) before re-applying this label.

@fluttergithubbot fluttergithubbot removed the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Nov 30, 2021
@ColdPaleLight ColdPaleLight added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Nov 30, 2021
@fluttergithubbot fluttergithubbot merged commit d95ece7 into flutter:main Nov 30, 2021
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 30, 2021
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 30, 2021
@engine-flutter-autoroll
d95ece7 Add a comment in Image.toByteData to limit more encoders (flu…
5441e5f 
…tter/engine#29962)
@eggfly eggfly deleted the more_image_encoding_formats branch December 2, 2021 13:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@dnfield dnfield dnfield approved these changes

@tvolkert tvolkert tvolkert approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes needs tests platform-web Code specifically for the web engine waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@eggfly @fluttergithubbot @dnfield @tvolkert @ColdPaleLight