This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Win32: add test of native a11y tree nodes #29993
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chunhtai
reviewed
Nov 29, 2021
| ASSERT_EQ(node0_accessible->get_accChildCount(&node0_child_count), S_OK); | ||
| EXPECT_EQ(node0_child_count, 2); | ||
|
|
||
| { |
Member
Author
There was a problem hiding this comment.
Just to keep from re-using variables (the variables for reading name/value/role). Forces us to re-declare the locals to the expected values (the variants) so they don't get accidentally polluted by prior tests. From a readability pt of view, also avoids having to scroll back up to look at how some variable was initialised.
It'd be straightforward to remove the scopes if you like that better.
Contributor
There was a problem hiding this comment.
this looks good :), was just wondering whether this is part of the test.
Adds AddSemanticsNodeUpdateWithChildren, which tests that the native tree of IAccessible COM objects is an accurate representation of the platform-agnostic accessibility tree. Issue: flutter/flutter#77838
chunhtai
approved these changes
Nov 29, 2021
| ASSERT_EQ(node0_accessible->get_accChildCount(&node0_child_count), S_OK); | ||
| EXPECT_EQ(node0_child_count, 2); | ||
|
|
||
| { |
Contributor
There was a problem hiding this comment.
this looks good :), was just wondering whether this is part of the test.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 30, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds AddSemanticsNodeUpdateWithChildren, which tests that the native
tree of IAccessible COM objects is an accurate representation of the
platform-agnostic accessibility tree.
Issue: flutter/flutter#77838
Pre-launch Checklist
writing and running engine tests.
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.