Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@flar
Copy link
Contributor

@flar flar commented Dec 2, 2021

Reverts #30035

This looks like it might be causing a simulator error in the latest engine rolls, as seen in:
https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8828997122017962129/+/u/run_module_test_ios/test_stdout

@flutter-dashboard flutter-dashboard bot added the platform-web Code specifically for the web engine label Dec 2, 2021
@google-cla google-cla bot added the cla: yes label Dec 2, 2021
@flar flar requested a review from jmagman December 2, 2021 06:19
@flar
Copy link
Contributor Author

flar commented Dec 2, 2021

It looks like the latest engine roll went green on a rerun of the recipe in question even without this change. I'll let this run through its tests in case we find that the task remains flaky, but I'll mark it WIP so that we don't push it without further investigation.

@flar flar added the Work in progress (WIP) Not ready (yet) for review! label Dec 2, 2021
Copy link
Member

@jmagman jmagman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Framework tests wouldn't be impacted by #30035, it's just adding some prints to a script run in the engine Mac Web Engine builder.

@flar flar closed this Dec 2, 2021
@cbracken cbracken deleted the revert-30035-web-installer-roll branch May 10, 2022 21:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes platform-web Code specifically for the web engine Work in progress (WIP) Not ready (yet) for review!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants