Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[flutter_releases] Flutter stable 2.8.1 Engine Cherrypicks#30355

Merged
godofredoc merged 5 commits intoflutter:flutter-2.8-candidate.3from
godofredoc:cherrypicks-flutter-2.8-candidate.3
Dec 16, 2021
Merged

[flutter_releases] Flutter stable 2.8.1 Engine Cherrypicks#30355
godofredoc merged 5 commits intoflutter:flutter-2.8-candidate.3from
godofredoc:cherrypicks-flutter-2.8-candidate.3

Conversation

@godofredoc
Copy link
Contributor

@godofredoc godofredoc commented Dec 15, 2021

Flutter stable 2.8.1 Engine

Scheduled Cherrypicks

@flutter-dashboard
Copy link

flutter-dashboard bot commented Dec 15, 2021

This pull request was opened from and to a release candidate branch. This should only be done as part of the official Flutter release process. If you are attempting to make a regular contribution to the Flutter project, please close this PR and follow the instructions at Tree Hygiene for detailed instructions on contributing to Flutter.

Reviewers: Use caution before merging pull requests to release branches. Ensure the proper procedure has been followed.

@godofredoc @jmagman
Update shell/platform/darwin/ios/framework/Source/FlutterViewControll…
c6e868b 
…erTest.mm

Co-authored-by: Jenn Magder <magder@google.com>
@godofredoc
Copy link
Contributor Author

godofredoc commented Dec 16, 2021

Linux Android Debug Engine and Mac Unopt failures are related to a linter available on new recipes. These tests will pass on post-submit.

devoncarew
devoncarew approved these changes Dec 16, 2021
View reviewed changes
Copy link
Contributor

@devoncarew devoncarew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like this is reving the dart version, patching in a single engine cherry pick, and merging into flutter-2.8-candidate.3; lgtm

jmagman
jmagman approved these changes Dec 16, 2021
View reviewed changes
Copy link
Member

@jmagman jmagman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@godofredoc godofredoc merged commit 890a5fc into flutter:flutter-2.8-candidate.3 Dec 16, 2021
@godofredoc godofredoc deleted the cherrypicks-flutter-2.8-candidate.3 branch January 31, 2022 19:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@jmagman jmagman jmagman approved these changes

@devoncarew devoncarew devoncarew approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@godofredoc @jmagman @devoncarew @zhongwuzw