Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Don't retain the MTLTexture or MTLDevice in TestMetalContext #30832

Merged
gw280 merged 3 commits into from
Jan 13, 2022
Merged

Don't retain the MTLTexture or MTLDevice in TestMetalContext #30832

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
21adc3b
Don't retain the MTLTexture or MTLTextureDescriptor
Jan 13, 2022
4f673c2
Don't double release
Jan 13, 2022
7629cd7
MTLTextureDescriptor is already in the autorelease pool, so the retai…
Jan 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions testing/test_metal_context.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
namespace flutter {

TestMetalContext::TestMetalContext() {
auto device = fml::scoped_nsprotocol{[MTLCreateSystemDefaultDevice() retain]};
auto device = fml::scoped_nsprotocol{MTLCreateSystemDefaultDevice()};
if (!device) {
FML_LOG(ERROR) << "Could not acquire Metal device.";
return;
Expand Down Expand Up @@ -82,8 +82,7 @@
}

id<MTLDevice> device = (__bridge id<MTLDevice>)GetMetalDevice();
sk_cfp<void*> texture =
sk_cfp<void*>{[[device newTextureWithDescriptor:texture_descriptor.get()] retain]};
sk_cfp<void*> texture = sk_cfp<void*>{[device newTextureWithDescriptor:texture_descriptor.get()]};

if (!texture) {
FML_CHECK(false) << "Could not create texture from texture descriptor.";
Expand Down