Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@dkwingsmt
Copy link
Contributor

@dkwingsmt dkwingsmt commented Mar 16, 2022

Fixes flutter/flutter#99297.

In extremely rare cases, the modifier flags of an event will contradict to the event itself. This occurs on Chrome on Linux while holding ShiftLeft, where the MetaLeft down event has metaKey true, while the Meta up event has metaKey false.

This PR fixes it by ignoring the key of the current event during synthesization. After all, the current event is a ground truth.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added the platform-web Code specifically for the web engine label Mar 16, 2022
@dkwingsmt dkwingsmt requested a review from gspencergoog March 16, 2022 13:20
@dkwingsmt dkwingsmt changed the title [Web, Keyboard] Fix unreasonable modifier flags on ShiftLeft+MetaLeft [Web, Keyboard] Handle unreasonable modifier flags on ShiftLeft+MetaLeft Mar 16, 2022
Copy link
Contributor

@gspencergoog gspencergoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

32384589-a60f0e74-c078-11e7-9bc1-e5b5287aea9d

You might consider filing an issue with the Chrome team about this: it seems like a bug on their part.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

platform-web Code specifically for the web engine

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Linux Web] Pressing super key throws error "Attempted to send a key down event when no keys are in keysPressed."

2 participants