Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Revert "[web] Remove the --passfail flag when calling goldctl in post-submit" #32087

Merged
mdebbar merged 1 commit into from
Mar 18, 2022
Merged

Revert "[web] Remove the --passfail flag when calling goldctl in post-submit" #32087

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions web_sdk/web_test_utils/lib/skia_client.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,6 +137,7 @@ class SkiaGoldClient {
'--commit', commitHash,
'--keys-file', keys.path,
'--failure-file', failures.path,
'--passfail',
];

if (imgtestInitCommand.contains(null)) {
Expand Down Expand Up @@ -227,9 +228,6 @@ class SkiaGoldClient {
'--commit', commitHash,
'--keys-file', keys.path,
'--failure-file', failures.path,
// This is running in pre-submit so it's okay for the `goldctl` commands
// to fail when the images don't match. But during post-submit
// (in `_imgtestInit`) we shouldn't let the command fail.
'--passfail',
'--crs', 'github',
'--patchset_id', commitHash,
Expand Down