Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@cbracken
Copy link
Member

@cbracken cbracken commented Apr 6, 2022

This brings the Android accessibility bridge AccessibilityFeature enum
back in sync with the AccessibilityFeatures class in dart:ui, defined
in lib/ui/window.dart

Keeping these enums in sync aids in automated API consistency checking.

Issue: flutter/flutter#101217

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

This brings the Android accessibility bridge AccessibilityFeature enum
back in sync with the `AccessibilityFeatures` class in dart:ui, defined
in lib/ui/window.dart

Keeping these enums in sync aids in automated API consistency checking.

Issue: flutter/flutter#101217
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@cbracken
Copy link
Member Author

cbracken commented Apr 6, 2022

Tests to ensure enums remain in sync between dart:ui and the various platforms are added in #32408.

Copy link
Contributor

@chunhtai chunhtai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,

It will be good if we have some sort of test to ensure this...

@cbracken
Copy link
Member Author

cbracken commented Apr 6, 2022

It will be good if we have some sort of test to ensure this...

See #32408

@cbracken cbracken added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Apr 6, 2022
@fluttergithubbot fluttergithubbot merged commit 541b636 into flutter:main Apr 6, 2022
@cbracken cbracken deleted the missing-android-a11y-features branch April 6, 2022 23:58
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

needs tests platform-android waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants