-
Notifications
You must be signed in to change notification settings - Fork 6k
[icu] Update icu to 12de966fcbe1d1a48dba310aee63807856ffeee8 #33816
[icu] Update icu to 12de966fcbe1d1a48dba310aee63807856ffeee8 #33816
Conversation
|
Needs an update of the license parsing code. I think we had this somewhere in the prior attempt at updating this, so I will try to go there and see how the fix was done. |
|
#33274 has the needed license fixes, I think. |
|
Correction: #32879 |
ac7f1c1 to
afb9797
Compare
|
The change that is being checked now has a chance of passing all the licensing checks. |
afb9797 to
d36091a
Compare
d36091a to
69f30a1
Compare
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
@jason-simmons Would you mind approving this for merge if you are OK with the change? |
|
This pull request is not suitable for automatic merging in its current state.
|
Issue: flutter/flutter#105342
Rolls a very new version of the ICU library.
Fixes: flutter/flutter#87073
Pre-launch Checklist
writing and running engine tests.
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.