Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@jonahwilliams
Copy link
Contributor

@jonahwilliams jonahwilliams commented Jul 28, 2022

flutter/flutter#108471

Reverts toPictureSync and related code

@flutter-dashboard
Copy link

This pull request was opened from and to a release candidate branch. This should only be done as part of the official Flutter release process. If you are attempting to make a regular contribution to the Flutter project, please close this PR and follow the instructions at Tree Hygiene for detailed instructions on contributing to Flutter.

Reviewers: Use caution before merging pull requests to release branches. Ensure the proper procedure has been followed.

@CaseyHillers
Copy link
Contributor

FYI

org-dartlang-sdk:///flutter/lib/ui/painting.dart:4838:13: Error: The getter 'PictureRasterizationException' isn't defined for the class 'Canvas'.
 - 'Canvas' is from 'dart:ui'.
Try correcting the name to the name of an existing getter, or defining a getter or field named 'PictureRasterizationException'.
      throw PictureRasterizationException._(error, stack: image._debugStack);

Copy link
Contributor

@dnfield dnfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for doing this

@CaseyHillers
Copy link
Contributor

\cc @godofredoc whose's conducting next weeks release

@CaseyHillers CaseyHillers merged commit d1e7dc1 into flutter:flutter-3.2-candidate.5 Jul 28, 2022
@jonahwilliams jonahwilliams deleted the flutter-3.2-candidate.5 branch July 28, 2022 19:45
CaseyHillers pushed a commit to CaseyHillers/flutter that referenced this pull request Jul 28, 2022
CaseyHillers pushed a commit to flutter/flutter that referenced this pull request Jul 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

platform-web Code specifically for the web engine

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants