This repository was archived by the owner on Feb 25, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6k
Revert toPictureSync #34975
Merged
CaseyHillers
merged 4 commits into
flutter:flutter-3.2-candidate.5
from
jonahwilliams:flutter-3.2-candidate.5
Jul 28, 2022
Merged
Revert toPictureSync #34975
CaseyHillers
merged 4 commits into
flutter:flutter-3.2-candidate.5
from
jonahwilliams:flutter-3.2-candidate.5
Jul 28, 2022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was opened from and to a release candidate branch. This should only be done as part of the official Flutter release process. If you are attempting to make a regular contribution to the Flutter project, please close this PR and follow the instructions at Tree Hygiene for detailed instructions on contributing to Flutter. Reviewers: Use caution before merging pull requests to release branches. Ensure the proper procedure has been followed. |
Contributor
|
FYI |
dnfield
approved these changes
Jul 28, 2022
Contributor
dnfield
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for doing this
Contributor
|
\cc @godofredoc whose's conducting next weeks release |
CaseyHillers
approved these changes
Jul 28, 2022
CaseyHillers
pushed a commit
to CaseyHillers/flutter
that referenced
this pull request
Jul 28, 2022
* Revert toPictureSync (flutter/engine#34975)
CaseyHillers
pushed a commit
to flutter/flutter
that referenced
this pull request
Jul 29, 2022
* Revert toPictureSync (flutter/engine#34975)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
flutter/flutter#108471
Reverts toPictureSync and related code