Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Make analyzer hints and warnings fatal #35013

Merged
auto-submit merged 1 commit into from
Jul 29, 2022
Merged

Make analyzer hints and warnings fatal #35013

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 13 additions & 13 deletions ci/analyze.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,31 +46,31 @@ echo "Using dart from $DART_BIN"
"$DART" --version
echo ""

"$DART" analyze "$FLUTTER_DIR/lib/ui"
"$DART" analyze --fatal-infos --fatal-warnings "$FLUTTER_DIR/lib/ui"

"$DART" analyze "$FLUTTER_DIR/lib/spirv"
"$DART" analyze --fatal-infos --fatal-warnings "$FLUTTER_DIR/lib/spirv"

"$DART" analyze "$FLUTTER_DIR/ci"
"$DART" analyze --fatal-infos --fatal-warnings "$FLUTTER_DIR/ci"

"$DART" analyze "$FLUTTER_DIR/flutter_frontend_server"
"$DART" analyze --fatal-infos --fatal-warnings "$FLUTTER_DIR/flutter_frontend_server"

"$DART" analyze "$FLUTTER_DIR/tools/licenses"
"$DART" analyze --fatal-infos --fatal-warnings "$FLUTTER_DIR/tools/licenses"

"$DART" analyze "$FLUTTER_DIR/testing/litetest"
"$DART" analyze --fatal-infos --fatal-warnings "$FLUTTER_DIR/testing/litetest"

"$DART" analyze "$FLUTTER_DIR/testing/benchmark"
"$DART" analyze --fatal-infos --fatal-warnings "$FLUTTER_DIR/testing/benchmark"

"$DART" analyze "$FLUTTER_DIR/testing/smoke_test_failure"
"$DART" analyze --fatal-infos --fatal-warnings "$FLUTTER_DIR/testing/smoke_test_failure"

"$DART" analyze "$FLUTTER_DIR/testing/dart"
"$DART" analyze --fatal-infos --fatal-warnings "$FLUTTER_DIR/testing/dart"

"$DART" analyze "$FLUTTER_DIR/testing/scenario_app"
"$DART" analyze --fatal-infos --fatal-warnings "$FLUTTER_DIR/testing/scenario_app"

"$DART" analyze "$FLUTTER_DIR/testing/symbols"
"$DART" analyze --fatal-infos --fatal-warnings "$FLUTTER_DIR/testing/symbols"

"$DART" analyze "$FLUTTER_DIR/tools/githooks"
"$DART" analyze --fatal-infos --fatal-warnings "$FLUTTER_DIR/tools/githooks"

"$DART" analyze "$FLUTTER_DIR/tools/clang_tidy"
"$DART" analyze --fatal-infos --fatal-warnings "$FLUTTER_DIR/tools/clang_tidy"

echo ""

Expand Down
5 changes: 5 additions & 0 deletions testing/scenario_app/lib/src/platform_view.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -701,8 +701,13 @@ class PlatformViewForTouchIOSScenario extends Scenario

late void Function() _nextFrame;

/// Whether gestures should be accepted or rejected.
final bool accept;

/// The platform view identifier.
final int id;

/// Whether touches should be rejected until the gesture ends.
final bool rejectUntilTouchesEnded;

@override
Expand Down