This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller] Map to Metal's NDC in the perspective projection utility #35394
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the perspective transform assumes OpenGL's NDC depth range of -1 to 1. This patch switches to Metal/Vulkan's range of 0 to 1.
For GLES, the compiler is already emitting the appropriate clip space conversion. For example, when given the following vertex shader as input...
...the compiler emits the following when targeting GLES:
Noticed this problem in impeller-cmake-example.