Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Fix race in PushingMutlipleFramesSetsUpNewRecordingCanvas. #35412

Merged
auto-submit merged 1 commit into from
Aug 15, 2022
Merged

Fix race in PushingMutlipleFramesSetsUpNewRecordingCanvas. #35412

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions shell/platform/embedder/tests/embedder_unittests_gl.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
#include "tests/embedder_test_context.h"
#define FML_USED_ON_EMBEDDER

#include <atomic>
#include <string>
#include <vector>

Expand Down Expand Up @@ -2030,16 +2031,15 @@ TEST_F(EmbedderTest,

constexpr size_t frames_expected = 10;
fml::CountDownLatch frame_latch(frames_expected);
static size_t frames_seen;
frames_seen = 0;
std::atomic_size_t frames_seen = 0;
context.AddNativeCallback("SignalNativeTest",
CREATE_NATIVE_ENTRY([&](Dart_NativeArguments args) {
frames_seen++;
frame_latch.CountDown();
}));
frame_latch.Wait();

ASSERT_EQ(frames_expected, frames_seen);
ASSERT_GE(frames_seen, frames_expected);

FlutterEngineShutdown(engine.release());
}
Expand Down Expand Up @@ -2071,16 +2071,15 @@ TEST_F(EmbedderTest,

constexpr size_t frames_expected = 10;
fml::CountDownLatch frame_latch(frames_expected);
static size_t frames_seen;
frames_seen = 0;
std::atomic_size_t frames_seen = 0;
context.AddNativeCallback("SignalNativeTest",
CREATE_NATIVE_ENTRY([&](Dart_NativeArguments args) {
frames_seen++;
frame_latch.CountDown();
}));
frame_latch.Wait();

ASSERT_EQ(frames_expected, frames_seen);
ASSERT_GE(frames_seen, frames_expected);

FlutterEngineShutdown(engine.release());
}
Expand Down