Do not override partial repaint support globally #35539
Conversation
flutter-dashboard
bot
added
embedder
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
This still needs a test. |
iskakaushik
force-pushed
the
fix/issue-109858
branch
from
5050727 to
ff85d52
Compare
| // The default window bound framebuffer on Android. | ||
| return GLFBOInfo{ | ||
| .fbo_id = 0, | ||
| .partial_repaint_enabled = onscreen_surface_->SupportsPartialRepaint(), |
There was a problem hiding this comment.
The version in place before #35022 landed was this https://github.com/flutter/engine/pull/35022/files#:~:text=framebuffer%20on%20Android.-,return%200%3B,-return%20GLFBOInfo%7B. It did not pass any sort of information besides the fbo_id, which makes me think that this might not be the problem yet.
This needs to happen at a delegate level. fixes: flutter/flutter#109858
iskakaushik
force-pushed
the
fix/issue-109858
branch
from
ff85d52 to
3d874d8
Compare
| if (!framebuffer_info.existing_damage.has_value()) { | ||
| framebuffer_info.existing_damage = existing_damage_; | ||
| } |
There was a problem hiding this comment.
This looks good to me! It should work given that FBOResetAfterPresent is not always called and it should also work if FBO was indeed reset and the Embedder passed information about the existing damage.
iskakaushik
added
autosubmit
2 participants
This needs to happen at a delegate level.
fixes: flutter/flutter#109858