This repository was archived by the owner on Feb 25, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6k
Roll dart to 4738c1a1a514a1b4ed9f4df17f71e2c5d9011d7a #35691
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes since last dart roll ``` 4738c1a Version 2.19.0-137.0.dev 84a39b0 [infra] Disable Goma on dartk-linux-release-riscv64-qemu. 69fcdc8 Version 2.19.0-136.0.dev c0e74c4 [dart fix] report undefined diagnostics 7dfe682 Migration: _task is non-null 310d6d0 First draft of some process docs for the analyzer 39a6717 [vm] Don't run DFE with a low optimization threshold in profiler tests. ece330a [analysis_server] Include annotation completions at end of class 2f3c69c Rename a subdirectory under doc to match what analysis_server has 00f032a [ VM / Service ] Add isolateGroupId to IsolateRef and Isolate 992672b [gardening] Fix gcc bot - add suggested parenthesis around '&&' within '||' 33846f3 [io/file] Add `exclusive` optional parameter to File.create, createSync. f73f25e Revert to clang toolchain that was rolled in March 2b27d32 Report duplicated field names in record literals 65b4621 Fix an exception when a record type appears in an extends clause 8a883fa Change `:` to `=` for default values in `pkg`. 177147b [analysis_server] Improve handling of document modifications while computing completions dbac2a4 [cfe] Add InternalRecordLiteral ```
zanderso
approved these changes
Aug 25, 2022
jonahwilliams
approved these changes
Aug 25, 2022
Contributor
jonahwilliams
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 25, 2022
zanderso
added a commit
to zanderso/engine
that referenced
this pull request
Aug 25, 2022
This reverts commit 9600c6c.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 25, 2022
GaryQian
pushed a commit
to GaryQian/engine
that referenced
this pull request
Aug 25, 2022
* Roll dart to 4738c1a Changes since last dart roll ``` 4738c1a Version 2.19.0-137.0.dev 84a39b0 [infra] Disable Goma on dartk-linux-release-riscv64-qemu. 69fcdc8 Version 2.19.0-136.0.dev c0e74c4 [dart fix] report undefined diagnostics 7dfe682 Migration: _task is non-null 310d6d0 First draft of some process docs for the analyzer 39a6717 [vm] Don't run DFE with a low optimization threshold in profiler tests. ece330a [analysis_server] Include annotation completions at end of class 2f3c69c Rename a subdirectory under doc to match what analysis_server has 00f032a [ VM / Service ] Add isolateGroupId to IsolateRef and Isolate 992672b [gardening] Fix gcc bot - add suggested parenthesis around '&&' within '||' 33846f3 [io/file] Add `exclusive` optional parameter to File.create, createSync. f73f25e Revert to clang toolchain that was rolled in March 2b27d32 Report duplicated field names in record literals 65b4621 Fix an exception when a record type appears in an extends clause 8a883fa Change `:` to `=` for default values in `pkg`. 177147b [analysis_server] Improve handling of document modifications while computing completions dbac2a4 [cfe] Add InternalRecordLiteral ``` * Update license hash
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes since last dart roll
Manual roll since it required changes to DEPS for second instance of package/file