This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller] Render on Simulator #35692
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Oh, and I'm leaving instancing as working because why not? We could just remove it, it's not used anywhere - but I let's just do that in a separate patch if we're going to. |
dnfield
commented
Aug 25, 2022
| baseVertex:command.base_vertex | ||
| baseInstance:0u]; | ||
|
|
||
| if (command.instance_count != 1u) { |
Contributor
Author
There was a problem hiding this comment.
We already do an early return if it == 0u above.
chinmaygarde
approved these changes
Aug 25, 2022
dnfield
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 25, 2022
GaryQian
pushed a commit
to GaryQian/engine
that referenced
this pull request
Aug 25, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes flutter/flutter#104743
Simulator more or less restricts to Apple2. That means no instanced rendering. It's not clear to me if some of the sampling stuff would break either, but it isn't breaking currently on the test apps I'm looking at. Also means that we have to use the same uniform alignment as for macOS. I thought we couldn't use memoryless textures but that seems to be working.
The
SurfaceFramechange is because usingSK_ScalarMaxoverflows anint32_t, and Skia internally treats the clip as empty if you try to create an SkCanvas that overflowsint32_t. I'm not quite sure why this works on iPhones, but I'm going to bed now :)I've tested this patch on an Intel MBP, don't have access to an M1 at the moment to see what's going on there.
@jonahwilliams @zanderso @flar fyi